Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

回调支持多种签名和加密类型 #125

Merged
merged 9 commits into from
Oct 10, 2022
Merged

回调支持多种签名和加密类型 #125

merged 9 commits into from
Oct 10, 2022

Conversation

xy-peng
Copy link
Contributor

@xy-peng xy-peng commented Sep 29, 2022

回调处理器允许扩展不同的签名和解密组合。

// CipherSuite 算法套件，包括验签和解密
type CipherSuite struct {
	signatureType string
	validator     validators.WechatPayNotifyValidator
	aeadAlgorithm string
	aead          cipher.AEAD
}

这样的话，国密可以作为外部包提供的 CipherSuite，被回调处理器使用。

同时修订了文档，并提升了 testify 至最新版本。

EmmetZC
EmmetZC reviewed Sep 29, 2022
View reviewed changes
core/notify/notify.go Outdated Show resolved Hide resolved
@EmmetZC EmmetZC self-requested a review October 10, 2022 02:55
EmmetZC
EmmetZC approved these changes Oct 10, 2022
View reviewed changes
core/notify/notify.go Show resolved Hide resolved
@xy-peng xy-peng requested a review from alexkie007 October 10, 2022 07:14
@xy-peng xy-peng force-pushed the feat_multi_notify_handler branch from d9097fc to d4cd63a Compare October 10, 2022 08:34
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@xy-peng xy-peng merged commit cfa33b7 into main Oct 10, 2022
@EmmetZC EmmetZC deleted the feat_multi_notify_handler branch November 10, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkie007 alexkie007 alexkie007 approved these changes

@EmmetZC EmmetZC EmmetZC approved these changes

@Eric-Lee-Handyman Eric-Lee-Handyman Awaiting requested review from Eric-Lee-Handyman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xy-peng @EmmetZC @alexkie007